fuxino/simple_backup
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Add some exception handling

Browse Source
This commit is contained in:
daniele 2019-09-17 15:02:30 +02:00
parent 4c9a30d979
commit 5f0742874e
Signed by: fuxino
GPG Key ID: 6FE25B4A3EE16FDA
1 changed files with 68 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
simple-backup.py
View File

@ -81,13 +81,6 @@ class Backup():
self.errfile.write(err_message) self.errfile.write(err_message)
self.errfile.write('\n') self.errfile.write('\n')
# Fix ownership and permissions of log files if needed
if self.user != None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
self.logfile.close() self.logfile.close()
self.errfile.close() self.errfile.close()
self.warnfile.close() self.warnfile.close()
@ -109,13 +102,6 @@ class Backup():
self.errfile.write(err_message) self.errfile.write(err_message)
self.errfile.write('\n') self.errfile.write('\n')
# Fix ownership and permissions of log files if needed
if self.user != None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
self.logfile.close() self.logfile.close()
self.errfile.close() self.errfile.close()
self.warnfile.close() self.warnfile.close()
@ -183,13 +169,6 @@ class Backup():
self.errfile.write(err_message) self.errfile.write(err_message)
self.errfile.write('\n') self.errfile.write('\n')
# Fix ownership and permissions of log files if needed
if self.user != None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
self.logfile.close() self.logfile.close()
self.errfile.close() self.errfile.close()
self.warnfile.close() self.warnfile.close()
@ -208,12 +187,24 @@ class Backup():
# If previous backups exist, save link to the last backup # If previous backups exist, save link to the last backup
self.last_backup = self.backup_dir + '/last_backup' self.last_backup = self.backup_dir + '/last_backup'
if islink(self.last_backup): if islink(self.last_backup):
try:
self.last_backup = os.readlink(self.last_backup) self.last_backup = os.readlink(self.last_backup)
except:
print('An error occurred when reading the last_backup link')
exit(1)
else: else:
self.last_backup = '' self.last_backup = ''
self.backup_dir = self.backup_dir + '/' + date self.backup_dir = self.backup_dir + '/' + date
try:
os.makedirs(self.backup_dir) os.makedirs(self.backup_dir)
except PermissionError as e:
print(str(e))
exit(1)
except:
print('Failed to create backup directory')
exit(1)
return return
@ -287,12 +278,24 @@ class Backup():
#If previous backups exist, save link to the last backup #If previous backups exist, save link to the last backup
self.last_backup = self.backup_dir + '/last_backup' self.last_backup = self.backup_dir + '/last_backup'
if islink(self.last_backup): if islink(self.last_backup):
try:
self.last_backup = os.readlink(self.last_backup) self.last_backup = os.readlink(self.last_backup)
except:
print('An error occurred when reading the last_backup link')
exit(1)
else: else:
self.last_backup = '' self.last_backup = ''
self.backup_dir = self.backup_dir + '/' + date self.backup_dir = self.backup_dir + '/' + date
try:
os.makedirs(self.backup_dir) os.makedirs(self.backup_dir)
except PermissionError as e:
print(str(e))
exit(1)
except:
print('Failed to create backup directory')
exit(1)
i = i + 1 i = i + 1
elif var == '-e' or var == '--exclude': elif var == '-e' or var == '--exclude':
@ -340,8 +343,12 @@ class Backup():
exit(1) exit(1)
if not isdir(self.homedir + '/.simple_backup'): if not isdir(self.homedir + '/.simple_backup'):
try:
os.makedir(self.homedir + '/.simple_backup') os.makedir(self.homedir + '/.simple_backup')
print('Create directory "' + self.homedir + '/.simple_backup".') print('Created directory "' + self.homedir + '/.simple_backup".')
except:
print('Failed to create .simple_backup directory in HOME')
exit(1)
self.user = argv[i+1] self.user = argv[i+1]
@ -357,13 +364,6 @@ class Backup():
self.errfile.write(err_message) self.errfile.write(err_message)
self.errfile.write('\n') self.errfile.write('\n')
# Fix ownership and permissions of log files if needed
if self.user is not None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
self.logfile.close() self.logfile.close()
self.errfile.close() self.errfile.close()
self.warnfile.close() self.warnfile.close()
@ -419,11 +419,14 @@ def main():
if len(argv) == 1: if len(argv) == 1:
# If simple backup directory doesn't exist, create it and exit # If simple backup directory doesn't exist, create it and exit
if not isdir(backup.homedir + '/.simple_backup'): if not isdir(backup.homedir + '/.simple_backup'):
try:
os.makedir(backup.homedir + '/.simple_backup') os.makedir(backup.homedir + '/.simple_backup')
print('Created directory "' + backup.homedir + '/.simple_backup".') print('Created directory "' + backup.homedir + '/.simple_backup".')
print('Copy there the sample configuration and edit it') print('Copy there the sample configuration and edit it')
print('to your needs before running the backup,') print('to your needs before running the backup,')
print('or pass options on the command line.') print('or pass options on the command line.')
except:
print('Failed to create .simple_backup directory in HOME')
exit(1) exit(1)
@ -442,13 +445,6 @@ def main():
backup.errfile.write(err_message) backup.errfile.write(err_message)
backup.errfile.write('\n') backup.errfile.write('\n')
#Fix ownership and permissions of log files if needed
if backup.user is not None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
backup.logfile.close() backup.logfile.close()
backup.errfile.close() backup.errfile.close()
backup.warnfile.close() backup.warnfile.close()
@ -460,11 +456,14 @@ def main():
exit(1) exit(1)
elif backup.n_in == 0 and backup.backup_dir == '': elif backup.n_in == 0 and backup.backup_dir == '':
if not isdir(backup.homedir + '/.simple_backup'): if not isdir(backup.homedir + '/.simple_backup'):
try:
os.makedir(backup.homedir + '/.simple_backup') os.makedir(backup.homedir + '/.simple_backup')
print('Created directory "' + backup.homedir + '/.simple_backup".') print('Created directory "' + backup.homedir + '/.simple_backup".')
print('Copy there the sample configuration and edit it') print('Copy there the sample configuration and edit it')
print('to your needs before running the backup') print('to your needs before running the backup')
print('or pass options on the command line.') print('or pass options on the command line.')
except:
print('Failed to create .simple_backup directory in HOME')
exit(1) exit(1)
@ -480,13 +479,6 @@ def main():
backup.warnfile.write('\n') backup.warnfile.write('\n')
print(warn_message) print(warn_message)
#Fix ownership and permissions of log files if needed
if backup.user is None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
backup.logfile.close() backup.logfile.close()
backup.errfile.close() backup.errfile.close()
backup.warnfile.close() backup.warnfile.close()
@ -504,7 +496,11 @@ def main():
#If specified, keep the last n backups and remove the others. Default: keep all #If specified, keep the last n backups and remove the others. Default: keep all
if backup.keep > -1: if backup.keep > -1:
try:
dirs = os.listdir(backup.backup_dev + '/simple_backup') dirs = os.listdir(backup.backup_dev + '/simple_backup')
except:
print('Failed to list backup directory')
exit(1)
if dirs.count('last_backup') > 0: if dirs.count('last_backup') > 0:
dirs.remove('last_backup') dirs.remove('last_backup')
n_backup = len(dirs) - 1 n_backup = len(dirs) - 1
@ -558,13 +554,6 @@ def main():
backup.logfile.write('\n') backup.logfile.write('\n')
print('Backup finished') print('Backup finished')
# Fix ownership and permissions of log files if needed
if backup.user is not None:
pass
# chown $USER:$USER $LOG && chmod 644 $LOG
# chown $USER:$USER $ERR && chmod 644 $ERR
# chown $USER:$USER $WARN && chmod 644 $WARN
backup.logfile.close() backup.logfile.close()
# Copy log files in home directory # Copy log files in home directory
@ -573,13 +562,22 @@ def main():
move(backup.warn_path, backup.homedir + '/.simple_backup/warnings.log') move(backup.warn_path, backup.homedir + '/.simple_backup/warnings.log')
if islink(backup.backup_dev + '/simple_backup/last_backup'): if islink(backup.backup_dev + '/simple_backup/last_backup'):
try:
os.remove(backup.backup_dev + '/simple_backup/last_backup') os.remove(backup.backup_dev + '/simple_backup/last_backup')
except:
print('Failed to remove last_backup link')
try:
os.symlink(backup.backup_dir, backup.backup_dev + '/simple_backup/last_backup') os.symlink(backup.backup_dir, backup.backup_dev + '/simple_backup/last_backup')
except:
print('Failed to create last_backup link')
# Delete temporary files # Delete temporary files
try:
os.remove(backup.inputs_path) os.remove(backup.inputs_path)
os.remove(backup.exclude_path) os.remove(backup.exclude_path)
except:
print('Failed to remove temporary files')
exit(0) exit(0)