Make script more robus

Fix few bugs and make it more generic

PKGBUILD

@@ -3,11 +3,11 @@
 # Maintainer: Daniele Fucini <dfucini [at] gmail [dot] com>
 
 pkgname=update-notify
-pkgver=1.2.1
+pkgver=2.0
 pkgrel=1
 pkgdesc='Notify when updates are available'
 arch=('any')
-url="https://github.com/Fuxino/${pkgname}"
+url="https://git.shouldnt.work/fuxino/${pkgname}"
 license=('GPL-3.0-or-later')
 depends=('pacman-contrib'
          'aurutils')
@@ -15,7 +15,7 @@ makedepends=('git')
 optdepends=('git-monitor: to check git repos for updates')
 source=(git+${url}?signed#tag=${pkgver})
 validpgpkeys=('7E12BC1FF3B6EDB2CD8053EB981A2B2A3BBF5514')
-sha256sums=('cc5cd234450edfd423e47edcab05fb72265c1a8b9af2fc46f965f04199480956')
+sha256sums=('e96dbcc2b77750be03d89cdf3e1351c20c9079b7de1e129da0188dd3b30f6a03')
 
 package()
 {

update-notify

@@ -1,49 +1,117 @@
 #!/bin/bash
+set -u
 
-check_git_monitor()
-{
-    command -v git-monitor > /dev/null
-    echo "$?"
+# ---------------------------------------------------------------------------
+# Config
+# ---------------------------------------------------------------------------
+threshold=${1:-30}
+AUR_REPO="aur-local"
+# stock kernel package -> your custom build of it. Add or remove entries freely.
+declare -A KERNELS=(
+    [linux]="linux-custom"
+    [linux-lts]="linux-lts-custom"
+    [linux-zen]="linux-zen-custom"
+)
+state_dir="${XDG_STATE_HOME:-$HOME/.local/state}/check-updates"
+
+[[ $threshold =~ ^[0-9]+$ ]] || { echo "Threshold must be a number" >&2; exit 1; }
+mkdir -p "$state_dir"
+
+# notify-send from cron/systemd needs the session bus address
+export DBUS_SESSION_BUS_ADDRESS="${DBUS_SESSION_BUS_ADDRESS:-unix:path=/run/user/$(id -u)/bus}"
+
+# ---------------------------------------------------------------------------
+# Helpers
+# ---------------------------------------------------------------------------
+
+# Send a notification only if its body changed since last time for this key.
+notify_once() {
+    local key=$1 title=$2 body=$3
+    local file="$state_dir/$key"
+    if [[ -f $file && $(<"$file") == "$body" ]]; then
+        return 0
+    fi
+    printf '%s' "$body" > "$file"
+    notify-send "$title" "$body"
 }
 
-if [ "$#" -eq 1 ]; then
-    threshold=$1
+# Forget a key so the next occurrence notifies again.
+clear_state() {
+    rm -f "$state_dir/$1"
+}
+
+# If $1 has a pending update, print its new version and return 0.
+# checkupdates lines look like: "pkgname oldver -> newver"
+pending_version() {
+    local pkg=$1 item new
+    for item in "${arch_list[@]}"; do
+        if [[ $item == "$pkg "* ]]; then
+            read -r _ _ _ new <<< "$item"
+            printf '%s\n' "$new"
+            return 0
+        fi
+    done
+    return 1
+}
+
+# ---------------------------------------------------------------------------
+# Gather updates
+# ---------------------------------------------------------------------------
+
+# Fetch checkupdates once. Exit codes: 0 = updates, 2 = none, 1 = error.
+checkupdates_out=$(checkupdates 2>/dev/null)
+checkupdates_rc=$?
+if (( checkupdates_rc == 1 )); then
+    echo "checkupdates failed (network or sync problem?)" >&2
+fi
+
+arch_list=()
+if [[ -n $checkupdates_out ]]; then
+    mapfile -t arch_list <<< "$checkupdates_out"
+fi
+arch_updates=${#arch_list[@]}
+
+aur_updates=0
+if command -v aur >/dev/null 2>&1; then
+    aur_updates=$(aur repo -u -d "$AUR_REPO" 2>/dev/null | wc -l)
+fi
+updates=$((arch_updates + aur_updates))
+
+# ---------------------------------------------------------------------------
+# Kernel check: the stock kernel updated, but your custom build didn't
+# ---------------------------------------------------------------------------
+for stock_pkg in "${!KERNELS[@]}"; do
+    custom_pkg=${KERNELS[$stock_pkg]}
+
+    # Only relevant if the custom kernel is installed and has no pending update itself
+    if pacman -Q "$custom_pkg" >/dev/null 2>&1 && ! pending_version "$custom_pkg" >/dev/null; then
+        if stock_ver=$(pending_version "$stock_pkg"); then
+            notify_once "kernel-$stock_pkg" "Kernel update available: $stock_pkg" \
+                "Rebuild $custom_pkg ($stock_pkg $stock_ver)"
+            continue
+        fi
+    fi
+    clear_state "kernel-$stock_pkg"
+done
+
+# ---------------------------------------------------------------------------
+# General updates threshold
+# ---------------------------------------------------------------------------
+if (( updates >= threshold )); then
+    notify_once "updates" "Updates available" "Arch: $arch_updates, AUR: $aur_updates"
+
+    hints=(
+        "git-monitor|Check git packages|Use git-monitor for git packages updates"
+        "fwupdmgr|Check firmware|Use fwupdmgr to check for firmware updates"
+    )
+    for hint in "${hints[@]}"; do
+        IFS='|' read -r cmd title body <<< "$hint"
+        if command -v "$cmd" >/dev/null 2>&1; then
+            notify_once "hint-$cmd" "$title" "$body"
+        fi
+    done
 else
-    threshold=30
-fi
-
-arch_updates=$(checkupdates | wc -l)
-aur_updates=$(aur repo -u -d aur-local | wc -l)
-kernel_update=$(checkupdates | grep linux | grep -v custom | grep -v archlinux | grep -v api | grep -v firmware | grep -v util | wc -l)
-kernel_update_lts=$(checkupdates | grep linux-lts | grep -v custom | wc -l)
-git_monitor=$(check_git_monitor)
-lts_kernel=$(uname -r | grep lts | wc -l)
-
-if [ "$kernel_update" -eq 0 ] && [ "$lts_kernel" -eq 0 ]; then
-    kernel_update=$(vercmp `pacman -Si linux | grep Version | cut -d':' -f2` `uname -r`)
-fi
-
-if [ "$kernel_update_lts" -eq 0 ] && [ "$lts_kernel" -eq 1 ]; then
-    kernel_update_lts=$(vercmp `pacman -Si linux-lts | grep Version | cut -d':' -f2` `uname -r`)
-fi
-
-built_kernel=$(checkupdates | grep linux-custom | wc -l)
-built_kernel_lts=$(checkupdates | grep linux-lts-custom | wc -l)
-
-updates=$(($arch_updates + $aur_updates))
-
-if [ "$kernel_update" -ge 1 ] && [ "$built_kernel" -eq 0 ] && [ "$lts_kernel" -eq 0 ]; then
-    notify-send "Kernel update available" "Rebuild custom kernel"
-fi
-
-if [ "$kernel_update_lts" -ge 1 ] && [ "$built_kernel_lts" -eq 0 ] && [ "$lts_kernel" -eq 1 ]; then
-    notify-send "LTS Kernel update available" "Rebuild custom kernel"
-fi
-
-if [ "$updates" -ge "$threshold" ]; then
-    notify-send "Updates available" "Arch: $arch_updates, AUR: $aur_updates"
-
-    if [ "$git_monitor" -eq 0 ]; then
-        notify-send "Check git packages" "Use git-monitor for git packages updates"
-    fi
+    clear_state "updates"
+    clear_state "hint-git-monitor"
+    clear_state "hint-fwupdmgr"
 fi

update-notify.timer

@@ -3,7 +3,7 @@ Description=Run update-notify every 6 hours
 
 [Timer]
 OnBootSec=5min
-OnUnitActiveSec=6h
+OnUnitActiveSec=12h
 Persistent=true
 
 [Install]